Skip to content

Commit f50c202

Browse files
Rename and patch comments
1 parent 85c90ad commit f50c202

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

kernel/src/table_changes/log_replay.rs

+3-9
Original file line numberDiff line numberDiff line change
@@ -119,14 +119,8 @@ struct LogReplayScanner {
119119
// The commit file that this replay scanner will operate on.
120120
commit_file: ParsedLogPath,
121121
// The timestamp associated with this commit. This is the file modification time
122-
// from the commit's [`FileMeta`].
123-
//
124-
//
125-
// TODO when incommit timestamps are supported: If there is a [`CommitInfo`] with a timestamp
122+
// from the commit's [`FileMeta`]. If there is a [`CommitInfo`] with a timestamp
126123
// generated by in-commit timestamps, that timestamp will be used instead.
127-
//
128-
// Note: This will be used once an expression is introduced to transform the engine data in
129-
// [`TableChangesScanData`]
130124
timestamp: i64,
131125
}
132126

@@ -361,11 +355,11 @@ impl RowVisitor for PreparePhaseVisitor<'_> {
361355
let protocol =
362356
ProtocolVisitor::visit_protocol(i, min_reader_version, &getters[12..=15])?;
363357
self.protocol = Some(protocol);
364-
} else if let Some(timestamp) =
358+
} else if let Some(in_commit_timestamp) =
365359
getters[16].get_long(i, "commitInfo.inCommitTimestamp")?
366360
{
367361
if self.is_first_batch && i == 0 {
368-
*self.commit_timestamp = timestamp;
362+
*self.commit_timestamp = in_commit_timestamp;
369363
}
370364
}
371365
}

0 commit comments

Comments
 (0)