Skip to content

Commit 7243c36

Browse files
committed
fix naming
1 parent eb925a1 commit 7243c36

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

kernel/src/table_changes/log_replay.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ pub(crate) fn table_changes_action_iter(
6666
)
6767
}) //Iterator-Result-Iterator-Result
6868
.map(move |processed_commit| -> DeltaResult<_> {
69-
commit_to_scan_batches(processed_commit?, engine.clone(), filter.clone())
69+
cdf_commit_to_scan_batches(processed_commit?, engine.clone(), filter.clone())
7070
})
7171
.flatten_ok() // Iterator-Result-Result
7272
.map(|x| x?); // Iterator-Result
@@ -217,7 +217,6 @@ fn process_cdf_commit(
217217
// same as an `add` action.
218218
remove_dvs.retain(|rm_path, _| add_paths.contains(rm_path));
219219
}
220-
221220
Ok(ProcessedCdfCommit {
222221
timestamp: commit_file.location.last_modified,
223222
commit_file,
@@ -229,7 +228,7 @@ fn process_cdf_commit(
229228
/// Generates an iterator of [`TableChangesScanData`] by iterating over each action of the
230229
/// commit, generating a selection vector, and transforming the engine data. This performs
231230
/// phase 2 of [`LogReplayScanner`].
232-
fn commit_to_scan_batches(
231+
fn cdf_commit_to_scan_batches(
233232
processed_commit: ProcessedCdfCommit,
234233
engine: Arc<dyn Engine>,
235234
filter: Option<Arc<DataSkippingFilter>>,

kernel/src/table_changes/mod.rs

+2-7
Original file line numberDiff line numberDiff line change
@@ -151,13 +151,8 @@ impl TableChanges {
151151
let end_snapshot = Snapshot::try_new(table_root.as_url().clone(), engine, end_version)?;
152152

153153
// Verify CDF is enabled at the beginning and end of the interval using
154-
// [`check_cdf_table_properties`] to fail early. This also ensures that column mapping is
155-
// disabled.
156-
//
157-
// We also check the [`Protocol`] using [`ensure_cdf_read_supported`] to verify that
158-
// we support CDF with those features enabled.
159-
//
160-
// Note: We must still check each metadata and protocol action in the CDF range.
154+
// [`TableConfiguration::is_cdf_read_supported`] to fail early. This also ensures that
155+
// column mapping is disabled.
161156
let check_table_config = |snapshot: &Snapshot| {
162157
if snapshot.table_configuration().is_cdf_read_supported() {
163158
Ok(())

0 commit comments

Comments
 (0)