Refactor checkpoint conversion script for improved readability and efficiency #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchirmehta07
suggested changes
Feb 13, 2025
Comment on lines
+80
to
+89
| if "experts" in name and "shared_experts" not in name: | ||
| idx = int(name.split(".")[-3]) | ||
| target_index = idx // n_local_experts | ||
| if target_index < mp: | ||
| state_dicts[target_index][name] = param | ||
| elif dim is not None: | ||
| assert param.size(dim) % mp == 0, f"Dimension {dim} must be divisible by {mp}" | ||
| shard_size = param.size(dim) // mp | ||
| for i in range(mp): | ||
| state_dicts[i][name] = param[:, i * shard_size : (i + 1) * shard_size] if dim == 1 else param[i * shard_size : (i + 1) * shard_size] |
There was a problem hiding this comment.
We can add comments here for better clarity.
| @@ -43,46 +44,55 @@ def main(hf_ckpt_path, save_path, n_experts, mp): | |||
| Returns: | |||
| None | |||
| """ | |||
| assert mp > 0, "Model parallelism (mp) must be greater than 0" | |||
|
|
|||
| torch.set_num_threads(8) | |||
| n_local_experts = n_experts // mp | |||
| state_dicts = [{} for _ in range(mp)] | |||
There was a problem hiding this comment.
Add a comment to define state_dicts variable
Programmer-RD-AI
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.joinwithPathlibfor improved readability and efficiencyPath.glob()instead ofglob(os.path.join(...))for file operationsPath.mkdir(parents=True, exist_ok=True).narrow()with Python slicing for improved readabilitymp > 0before proceeding.replace()operation