Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in latest commit #1

Open
mm765 opened this issue Jan 7, 2016 · 10 comments
Open

Typo in latest commit #1

mm765 opened this issue Jan 7, 2016 · 10 comments

Comments

@mm765
Copy link

mm765 commented Jan 7, 2016

BSON.js deserialize: toStrring() (double r),
other than that, it works for my very small test, thanks.

@mm765
Copy link
Author

mm765 commented Jan 18, 2016

Push -
This is the one i mentioned in the decaf-thread, but maybe this is fixed in bower, too, so i didn't see it ?!

@mschwartz
Copy link
Contributor

Can you tell me what line number in the file is wrong, what it says and what it should say?

Thanks

@mschwartz
Copy link
Contributor

Bower simply does something like a git clone when you do "bower install."
When you do "bower update" it will do the equivalent of a git pull. If
you are not using bower, then I can't help more without knowing how exactly
you installed things.

On Mon, Jan 18, 2016 at 10:55 AM, mm765 [email protected] wrote:

Push -
This is the one i mentioned in the decaf-thread, but maybe this is fixed
in bower, too, so i didn't see it ?!


Reply to this email directly or view it on GitHub
#1 (comment)
.

@mm765
Copy link
Author

mm765 commented Jan 18, 2016

Sorry for the sloppy description.
In BSON.js line 61 reads
return String(o.toStrring());
it should be
return String(o.toString());

@mm765
Copy link
Author

mm765 commented Jan 18, 2016

As to how i installed it - i simply cloned the repositories from github.
Now when i do a git pull it says i am up to date (for this and also for the decafjs repository) and also github does show the last date of change to be about 10 days ago - so it seems the github repository has not been updated.

@mschwartz
Copy link
Contributor

I don't see the mistake :)

On Mon, Jan 18, 2016 at 2:34 PM, mm765 [email protected] wrote:

Sorry for the sloppy description.
In BSON.js line 61 reads
return String(o.toStrring());
it should be
return String(o.toString());


Reply to this email directly or view it on GitHub
#1 (comment)
.

@mschwartz
Copy link
Contributor

NVM, I found it and pushed the typo fix.

On Mon, Jan 18, 2016 at 3:03 PM, Mike Schwartz [email protected] wrote:

I don't see the mistake :)

On Mon, Jan 18, 2016 at 2:34 PM, mm765 [email protected] wrote:

Sorry for the sloppy description.
In BSON.js line 61 reads
return String(o.toStrring());
it should be
return String(o.toString());


Reply to this email directly or view it on GitHub
#1 (comment)
.

@mm765
Copy link
Author

mm765 commented Jan 18, 2016

:) there are two "r"s in the toString
Double rr
Hope this helps :)

@mm765
Copy link
Author

mm765 commented Jan 18, 2016

Ok, and this one also shows up on github and was sent to me on a git pull.

@mschwartz
Copy link
Contributor

I thought so :)

On Mon, Jan 18, 2016 at 3:11 PM, mm765 [email protected] wrote:

Ok, and this one also shows up on github and was sent to me on a git pull.


Reply to this email directly or view it on GitHub
#1 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants