test(wdl-engine): add unit test for workflow graph input dependencies

- Add sample test from stjude-rust-labs#356
- fix typo
- remove debugging logs
- update changelog
- format files
- remove unncecessary to_string() calls

Author: dead8309

wdl-analysis/src/document/v1.rs

@@ -850,7 +850,8 @@ fn populate_workflow(
     )];
     let mut output_scope = None;
 
-    // For static analysis, we don't need to provide inputs to the workflow graph builder
+    // For static analysis, we don't need to provide inputs to the workflow graph
+    // builder
     let graph =
         WorkflowGraphBuilder::default().build(workflow, &mut document.diagnostics, |_| false);
 

wdl-analysis/src/eval/v1.rs

@@ -1109,3 +1109,124 @@ impl<N: TreeNode> Default for CommonAncestorFinder<N> {
         }
     }
 }
+
+#[cfg(test)]
+mod test {
+    use wdl_ast::Document;
+
+    use super::*;
+
+    #[test]
+    fn test_input_dependency_handling() {
+        let source = r#"
+        version 1.1
+
+        task my_task {
+            input {
+                Int i
+            }
+
+            command <<<>>>
+
+            output {
+                Int out = i
+            }
+        }
+
+        workflow foo {
+            input {
+                Int x = 10
+                Int y = t1.out
+            }
+
+            call my_task as t1 { input: i = x }
+            call my_task as t2 { input: i = y }
+        }
+        "#;
+
+        let (document, diagnostics) = Document::parse(source);
+        assert!(
+            diagnostics.is_empty(),
+            "parsing should succeed without diagnostics"
+        );
+
+        let workflow = document
+            .ast()
+            .into_v1()
+            .expect("document should be v1")
+            .workflows()
+            .next()
+            .expect("document should have a workflow");
+
+        let mut diagnostics = Vec::new();
+
+        // Testing without providing inputs i.e. static analysis
+        let graph = WorkflowGraphBuilder::default().build(&workflow, &mut diagnostics, |_| false);
+
+        let t1_out = graph
+            .node_indices()
+            .find(|i| {
+                if let WorkflowGraphNode::Call(call) = &graph[*i] {
+                    call.alias().map(|a| a.name().text().to_string()) == Some("t1".to_string())
+                } else {
+                    false
+                }
+            })
+            .expect("t1 node not found");
+
+        let y = graph
+            .node_indices()
+            .find(|i| {
+                if let WorkflowGraphNode::Input(input) = &graph[*i] {
+                    input.name().text() == "y"
+                } else {
+                    false
+                }
+            })
+            .expect("y node not found");
+
+        assert!(
+            graph.contains_edge(t1_out, y),
+            "y should depend on t1.out when input 'y' is not provided"
+        );
+
+        let y_input = graph
+            .node_indices()
+            .find(|i| {
+                if let WorkflowGraphNode::Input(input) = &graph[*i] {
+                    input.name().text() == "y"
+                } else {
+                    false
+                }
+            })
+            .expect("y node not found");
+
+        let t2 = graph
+            .node_indices()
+            .find(|i| {
+                if let WorkflowGraphNode::Call(call) = &graph[*i] {
+                    call.alias().map(|a| a.name().text().to_string()) == Some("t2".to_string())
+                } else {
+                    false
+                }
+            })
+            .expect("t2 node not found");
+
+        assert!(graph.contains_edge(y_input, t2), "t2 should depend on y");
+
+        // Testing with providing input y i.e. runtime analysis - case for wdl_engine
+        let mut diagnostics = Vec::new();
+        let graph =
+            WorkflowGraphBuilder::default().build(&workflow, &mut diagnostics, |name| name == "y");
+
+        assert!(
+            !graph.contains_edge(t1_out, y),
+            "y should not depend on t1.out when input 'y' is provided"
+        );
+
+        assert!(
+            graph.contains_edge(y_input, t2),
+            "t2 should depend on y even when input y is provided"
+        );
+    }
+}

wdl-engine/CHANGELOG.md

@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Fixed path translation to mount inputs individually (#[327](https://github.com/stjude-rust-labs/wdl/pull/327)).
 * Fixed not including task temp directories in mounts (#[327](https://github.com/stjude-rust-labs/wdl/pull/327)).
 * Fixed an incorrect type being used for scatter statement outputs ([#316](https://github.com/stjude-rust-labs/wdl/pull/316)).
+* Fixed handling of input dependencies in workflow graph evaluation ([#360](https://github.com/stjude-rust-labs/wdl/pull/360)).
 
 ### Changed