Skip to content

Commit d2b3dde

Browse files
authored
fixed a missing space in delete-query in sybase-dialect (#28)
1 parent 8116166 commit d2b3dde

File tree

6 files changed

+20
-10
lines changed

6 files changed

+20
-10
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ A Java-Library to build SQL-Statements
2222
<dependency>
2323
<groupId>de.jaggl.sqlbuilder</groupId>
2424
<artifactId>sqlbuilder-core</artifactId>
25-
<version>2.7.0</version>
25+
<version>2.7.2</version>
2626
</dependency>
2727
```
2828

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
<groupId>de.jaggl.sqlbuilder</groupId>
55
<artifactId>sqlbuilder-core</artifactId>
6-
<version>2.7.1</version>
6+
<version>2.7.2</version>
77

88
<packaging>jar</packaging>
99

src/main/java/de/jaggl/sqlbuilder/core/dialect/SybaseDialect.java

+4
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ protected void appendSelectStatement(StringBuilder builder, Select select, Build
114114
protected void appendDeleteStatement(StringBuilder builder, Delete delete, BuildingContext context, Indentation indentation)
115115
{
116116
builder.append(context.getDialect().getLabels().getDelete());
117+
if (delete.getLimitation() == null)
118+
{
119+
builder.append(" ");
120+
}
117121
appendLimit(builder, delete.getLimitation(), context, indentation);
118122
if (delete.getLimitation() != null)
119123
{

src/test/java/de/jaggl/sqlbuilder/core/queries/DeleteTest.java

+7
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ class DeleteTest
2323
private static final VarCharColumn LASTNAME = PERSONS.varCharColumn("lastname").build();
2424
private static final IntColumn AGE = PERSONS.intColumn("age").build();
2525

26+
@Test
27+
void testBuildSimpleDelete()
28+
{
29+
assertThat(deleteFrom(PERSONS).where(LASTNAME.isEqualTo("Schumacher")).build(SYBASE))
30+
.isEqualTo("DELETE FROM `persons` WHERE `persons`.`lastname` = 'Schumacher'");
31+
}
32+
2633
@Test
2734
void testBuildDelete()
2835
{

src/test/java/de/jaggl/sqlbuilder/core/queries/QueryTest.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
import java.sql.PreparedStatement;
1515
import java.sql.SQLException;
1616

17-
import org.junit.Test;
17+
import org.junit.jupiter.api.Test;
1818

19-
public class QueryTest
19+
class QueryTest
2020
{
2121
@Test
22-
public void testPrintAndPrintln()
22+
void testPrintAndPrintln()
2323
{
2424
var query = select().from(create("table"));
2525

@@ -66,7 +66,7 @@ public void testPrintAndPrintln()
6666

6767
@SuppressWarnings("resource")
6868
@Test
69-
public void testPrepare() throws SQLException
69+
void testPrepare() throws SQLException
7070
{
7171
var query = select().from(create("table"));
7272

@@ -84,7 +84,7 @@ public void testPrepare() throws SQLException
8484

8585
@SuppressWarnings("resource")
8686
@Test
87-
public void testPrepareWithDialect() throws SQLException
87+
void testPrepareWithDialect() throws SQLException
8888
{
8989
var query = select().from(create("table"));
9090

@@ -102,7 +102,7 @@ public void testPrepareWithDialect() throws SQLException
102102

103103
@SuppressWarnings("resource")
104104
@Test
105-
public void testPrepareWithDialectName() throws SQLException
105+
void testPrepareWithDialectName() throws SQLException
106106
{
107107
var query = select().from(create("table"));
108108

src/test/java/de/jaggl/sqlbuilder/core/queries/QueryableQueryTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,12 @@
99

1010
import org.junit.jupiter.api.Test;
1111

12-
import de.jaggl.sqlbuilder.core.queries.Query;
1312
import de.jaggl.sqlbuilder.core.queryexecutor.SelectQueryExecutor;
1413
import de.jaggl.sqlbuilder.core.schema.Table;
1514
import lombok.AllArgsConstructor;
1615
import lombok.EqualsAndHashCode;
1716

18-
public class QueryableQueryTest
17+
class QueryableQueryTest
1918
{
2019
private static final Table TABLE = Table.create("table");
2120
private SelectQueryExecutor<MyClass> selectQueryExecutor = new MySelectQueryExecutor();

0 commit comments

Comments
 (0)