Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Proselint over commit messages? #8

Open
suchow opened this issue Jul 25, 2016 · 2 comments
Open

Run Proselint over commit messages? #8

suchow opened this issue Jul 25, 2016 · 2 comments

Comments

@suchow
Copy link
Contributor

suchow commented Jul 25, 2016

Nice work with this Danger plugin! I'll be using it on Proselint's GitHub repo soon (amperser/proselint#546).

Question — is it possible to use this to run Proselint over commit messages?

@orta
Copy link
Collaborator

orta commented Jul 25, 2016

Sure can - git.commits.map {|commit| commit.message } gives you the strings for all the commit messages 👍

Would recommend running bundle exec danger local --pry to open a REPL inside the Dangerfile and look around once it's set up

@orta
Copy link
Collaborator

orta commented Jul 25, 2016

Hrm, the current proselint plugin however is mainly built for working against files, so we'd either need to allow for arbitrary text, or you'll need to write the messages to a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants