Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub rate limit error #32

Open
AndrewSB opened this issue Feb 10, 2021 · 1 comment
Open

GitHub rate limit error #32

AndrewSB opened this issue Feb 10, 2021 · 1 comment

Comments

@AndrewSB
Copy link

AndrewSB commented Feb 10, 2021

hey! i help maintain Moya, and we're noticing an issue on our CI that may be related to this plugin

it looks like

Cloning and building inline dependencies: import DangerSwiftProse // package: https://github.com/f-meloni/danger-swift-prose.git, import DangerXCodeSummary // package: https://github.com/f-meloni/danger-swift-xcodesummary.git, this might take some time.
Updating packages...
Using https://github.com/f-meloni/danger-swift-prose.git latest major:1
Updating packages...
Using https://github.com/f-meloni/danger-swift-xcodesummary.git latest major:1
Updating packages...

Failing the build, there are 19 fails.
Request failed [422]: https://api.github.com/repos/Moya/Moya/pulls/2120/comments
Response: {
  "message": "Validation Failed",
  "errors": [
    {
      "resource": "PullRequestReviewComment",
      "code": "invalid",
      "field": "position"
    }
  ],
  "documentation_url": "https://docs.github.com/rest/reference/pulls#create-a-review-comment-for-a-pull-request"
}

we've noticed on repeated runs of this PR Moya/Moya#2120, and potentially now in our development branch now that we've merged the PR. before we dug deeper into it, i thought we'd check with y'all to see if you grok it, have seen it before, or know how to fix it?

i really appreciate all your work on this tool!

@orta
Copy link
Collaborator

orta commented Feb 10, 2021

maybe an inline comment is trying to comment on a line which doesn't exist in the diff anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants