Skip to content

Commit db24add

Browse files
authored
fix: mainnavigation underneath 1024px viewports (#1970)
* fix: we need that label element in general * updated test
1 parent a3befb9 commit db24add

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

packages/db-ui-elements-stencil/src/components/db-mainnavigation/__tests__/db-mainnavigation.spec.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ describe('db-mainnavigation', () => {
1111
<db-mainnavigation>
1212
<nav class="cmp-mainnavigation" id="mainnavigation">
1313
<input id="toggle_mainnavigation" type="checkbox">
14+
<label class="is-site-name" htmlfor="toggle_mainnavigation" title="Toggle main navigation"></label>
1415
<ul></ul>
1516
</nav>
1617
</db-mainnavigation>

packages/db-ui-elements-stencil/src/components/db-mainnavigation/db-mainnavigation.tsx

+7-9
Original file line numberDiff line numberDiff line change
@@ -137,15 +137,13 @@ export class DbMainnavigation {
137137
return (
138138
<nav class="cmp-mainnavigation" id="mainnavigation">
139139
<input type="checkbox" id="toggle_mainnavigation" />
140-
{this.siteName && (
141-
<label
142-
htmlFor="toggle_mainnavigation"
143-
title="Toggle main navigation"
144-
class="is-site-name"
145-
>
146-
{this.siteName}
147-
</label>
148-
)}
140+
<label
141+
htmlFor="toggle_mainnavigation"
142+
title="Toggle main navigation"
143+
class="is-site-name"
144+
>
145+
{this.siteName}
146+
</label>
149147
{this.compData && <ul innerHTML={getCompDataHtml(this.compData)} />}
150148
{!this.compData && (
151149
<ul>

0 commit comments

Comments
 (0)