Skip to content

Commit d19a51d

Browse files
committed
Revert "Dispatch an init event in the client to fix 10x trace state (opt-in)"
This reverts commit 0714488. A workaround that didn't work very well. Making progress on a real solution. See #263
1 parent 7b483be commit d19a51d

File tree

5 files changed

+2
-14
lines changed

5 files changed

+2
-14
lines changed

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,6 @@ name | description | type | example
279279
...`time-travel?` | selecting an event reverts your app-db | boolean | `true`
280280
...`ignored-libs` | ignore low-level trace | seq of keywords | `"[:reagent :re-frame]"`
281281
...`ns-aliases` | display aliased keywords in data inspectors | map of symbol->symbol | `"{long-namespace ln}"`
282-
...`init-event?` | lets 10x dispatch its own init event in your client re-frame (this fixes some [quirks](https://github.com/day8/re-frame-10x/issues/263)) | boolean | `false`
283282
284283
285284

examples/todomvc/shadow-cljs.edn

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
:closure-defines
1717
{re-frame.trace.trace-enabled? true
1818
day8.re-frame-10x.debug? true
19-
day8.re-frame.tracing.trace-enabled? true
20-
day8.re-frame-10x.init-event? true}
19+
day8.re-frame.tracing.trace-enabled? true}
2120
:external-config
2221
{:devtools/config
2322
{:features-to-install

src/day8/re_frame_10x.cljs

+1-3
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@
151151
(goog-define time-travel? true)
152152
(goog-define ignored-libs "[:reagent :re-frame]")
153153
(goog-define ns-aliases "{long-namespace ln}")
154-
(goog-define init-event? false)
155154

156155
(def project-config
157156
(let [read reader.edn/read-string-maybe
@@ -164,6 +163,5 @@
164163
:filtered-view-trace (some->> hidden-namespaces read (map view) sortable-uuid-map)
165164
:app-db-follows-events? time-travel?
166165
:low-level-trace (some-> ignored-libs read (pred-map #{:re-frame :reagent}))
167-
:ns-aliases (some->> ns-aliases read (map alias) sortable-uuid-map)
168-
:init-event? init-event?}
166+
:ns-aliases (some->> ns-aliases read (map alias) sortable-uuid-map)}
169167
(into {} keep-vals))))

src/day8/re_frame_10x/preload/react_17.cljs

-4
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@
2323

2424
(rf/dispatch-sync [::events/init re-frame-10x/project-config])
2525

26-
(when re-frame-10x/init-event?
27-
(re-frame.core/reg-event-db :day8.re-frame-10x/init (fn [db _] db))
28-
(re-frame.fx/dispatch-later {:ms 500 :dispatch [:day8.re-frame-10x/init]}))
29-
3026
(rf/clear-subscription-cache!)
3127

3228
(def shadow-root (re-frame-10x/create-shadow-root))

src/day8/re_frame_10x/preload/react_18.cljs

-4
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717

1818
(rf/dispatch-sync [::events/init re-frame-10x/project-config])
1919

20-
(when re-frame-10x/init-event?
21-
(re-frame.core/reg-event-db :day8.re-frame-10x/init (fn [db _] db))
22-
(re-frame.fx/dispatch-later {:ms 500 :dispatch [:day8.re-frame-10x/init]}))
23-
2420
(rf/clear-subscription-cache!)
2521

2622
(def shadow-root (re-frame-10x/create-shadow-root))

0 commit comments

Comments
 (0)