Skip to content

Commit 4689147

Browse files
authored
Remove sysroot -> isysroot patch now that the clangd bug is fixed
See hedronvision#82 and hedronvision#179 for context
1 parent f56c9e9 commit 4689147

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

Diff for: refresh.template.py

-5
Original file line numberDiff line numberDiff line change
@@ -870,11 +870,6 @@ def _all_platform_patch(compile_args: typing.List[str]):
870870
# For more context see: https://github.com/hedronvision/bazel-compile-commands-extractor/issues/21
871871
compile_args = (arg for arg in compile_args if not arg == '-fno-canonical-system-headers')
872872

873-
# Swap -isysroot in for --sysroot to work around some unknown sysroot bug in clangd.
874-
# For context, see https://github.com/hedronvision/bazel-compile-commands-extractor/issues/82
875-
# The = logic has to do with clang not accepting -isysroot=, but accepting --sysroot=. Note that -isysroot <path> is accepted, though undocumented.
876-
compile_args = ('-isysroot'+arg[len('--sysroot')+arg.startswith('--sysroot='):] if arg.startswith('--sysroot') else arg for arg in compile_args)
877-
878873
# Strip out -gcc-toolchain to work around https://github.com/clangd/clangd/issues/1248
879874
skip_next = False
880875
new_compile_args = []

0 commit comments

Comments
 (0)