Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke-DbaDbShrink, accept pipelined databases #9596

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Invoke-DbaDbShrink, accept pipelined databases #9596

wants to merge 3 commits into from
+163 −129

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Feb 21, 2025

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes Invoke-DbaDbShrink doesn't accept pipeline input #9495 )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (Invoke-ManualPester)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Given it's a -DbaDb* I tend to agree with the original reporter, which assumed pipelined databases "just work"

Approach

The usual dance around parametersets and pipelines

Commands to test

Added a regr test to make sure the feature stays in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke-DbaDbShrink doesn't accept pipeline input
1 participant
@niphlod