Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing result_renderer='disabled' for internal datalad command execution #241

Open
mih opened this issue Oct 10, 2023 · 0 comments
Open

Missing result_renderer='disabled' for internal datalad command execution #241

mih opened this issue Oct 10, 2023 · 0 comments

Comments

@mih
Copy link
Member

mih commented Oct 10, 2023

This is the case for, at least, the save calls in containers_add and containers_remove. This should disable the internal rendering of results,
because otherwise a user cannot control the verbosity.

When this is addressed, it makes sense to also start using return_type='generator' to avoid the present list-item-accumulation of results of internal command calls.
mih added a commit to mih/datalad-container that referenced this issue Oct 10, 2023
@mih
Reduce some of the noise in the test battery
9b95b78 
This is done by turning of the result rendering. This revealed that
the command implementations cause uncondtional result rendering
datalad#241
@mih mih mentioned this issue Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mih