Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for numpy >= 2.0.2 #432

Closed
envelio-cb opened this issue Aug 27, 2024 · 7 comments · May be fixed by #478
Closed

Support for numpy >= 2.0.2 #432

envelio-cb opened this issue Aug 27, 2024 · 7 comments · May be fixed by #478

Comments

@envelio-cb
Copy link

envelio-cb commented Aug 27, 2024 •
edited
Loading

I am working on upgrading our ecosystem to use numpy >= 2.0.2 which currently breaks at your package.

Afaik you don't use numpy in your code except for testing. Thus, I am wondering if you can either drop the dependency and add it as dev-only dependency or if you can be less strict in the versioning of numpy and support numpy >= 2.0.2.

Here is also a list of the numpy ecosystem compatibility with numpy 2.0:
numpy/numpy#26191

Kind regards
@envelio-cb envelio-cb changed the title Support for numpy >= 2.0.2 Support for numpy >= 2.0.2 and pandas >= 2.2.2 Aug 27, 2024
@envelio-cb envelio-cb changed the title Support for numpy >= 2.0.2 and pandas >= 2.2.2 Support for numpy >= 2.0.2 Aug 27, 2024
@arredond
Copy link
Contributor

arredond commented Oct 4, 2024

+1 to this! Also in general to not setting upper bounds to package versions unless strictly necessary.

I made a similar comment about this here #427 (similar case that's affecting us but for the pyarrow < 17.0 limitation

@arredond arredond mentioned this issue Oct 7, 2024
Merged
@sshevlyagin
Copy link

+1

1 similar comment
@jslorrma
Copy link

+1

@Bendik-ml
Copy link

+1 👯‍♂️

@janjagusch janjagusch mentioned this issue Dec 5, 2024
Open
@tblatrille
Copy link

+1

@jprakash-db
Copy link
Contributor

Pandas and numpy has compatiblity issues, numpy version 2 is only supported after pandas 2.2.2 and any version before that is not supported. - https://pandas.pydata.org/docs/whatsnew/v2.2.2.html#pandas-2-2-2-is-now-compatible-with-numpy-2-0

@rgommers
Copy link

Pandas and numpy has compatiblity issues, numpy version 2 is only supported after pandas 2.2.2 and any version before that is not supported

Newer versions of one package only being compatible with newer versions of another package is perfectly normal, rather than a problem that is relevant to this package. This is still a problem, so there is no reason to close this issue.

Also in general to not setting upper bounds to package versions unless strictly necessary.

That is entirely correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove upper bound for NumPy janjagusch/databricks-sql-python
8 participants
@rgommers @sshevlyagin @tblatrille @arredond @jslorrma @Bendik-ml @envelio-cb @jprakash-db