Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure with released validatedb and dev dbplyr #7

Open
mgirlich opened this issue Aug 31, 2022 · 4 comments
Open

Failure with released validatedb and dev dbplyr #7

mgirlich opened this issue Aug 31, 2022 · 4 comments

Comments

@mgirlich
Copy link

We see

  • checking tests ...
      Running ‘testthat.R’
     ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      ! Object `y` not found.
      ── Error (test-summary.R:32:5): summary: works with failing rules ──────────────
      Error in `dplyr::transmute(tbl, row = row_number(), rule = "V5", fail = !y > 
          0)`: Problem while computing `fail = !y > 0`
      Caused by error:
      ! Object `y` not found.
      ── Error (test-summary.R:73:5): summary: works with failing rules (sparse) ─────
      Error in `dplyr::transmute(tbl, row = row_number(), rule = "V5", fail = !y > 
          0)`: Problem while computing `fail = !y > 0`
      Caused by error:
      ! Object `y` not found.
      
      [ FAIL 3 | WARN 0 | SKIP 2 | PASS 26 ]
      Error: Test failures
      Execution halted
    

The problems comes from this change in dbplyr

  • Variables that are neither found in the data nor in the environment now
    produce an error (@mgirlich, #907).

We plan to release dbplyr soon so it would be great if you could fix this issue.

@mgirlich
Copy link
Author

mgirlich commented Dec 8, 2022

@edwindj @markvanderloo Would be great if you could fix this issue

@hadley
Copy link

hadley commented Dec 20, 2022

dbplyr is now scheduled for release on Jan 16; please let us know if there's anything we can do to help.

@edwindj
Copy link
Member

edwindj commented Jan 4, 2023

Ah, thanks will look into it this week (don't expect any problems solving it)

@hadley
Copy link

hadley commented Jan 13, 2023

Just a reminder that we're submitting to CRAN on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants