Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify extensions should live in specified namespaces #501

Closed
honno opened this issue Oct 31, 2022 · 3 comments
Closed

Clarify extensions should live in specified namespaces #501

honno opened this issue Oct 31, 2022 · 3 comments
Milestone

Comments

@honno
Copy link
Member

honno commented Oct 31, 2022

I noticed our newly introduced FFT stubs live in fourier_transform_functions.py, which might implicitly communicate those extensions should live in the xp.fourier_transform_functions namespace (xp being the top-level Array API namespace), where presumably we want adopters to use xp.fft like say NumPy has it.

So that can be renamed, but this brings up that there's no explicit clarification in the spec that the linalg and fft extensions should indeed live in those respective namespaces. I think a note could live in all extension pages (currently just Linear Algebra and Fourier transform Function) explaining that the respective functions should be present in these specific namespaces.

@honno
Copy link
Member Author

honno commented Nov 3, 2022

In todays meeting we were in agreement for both points (fourier_transform_functions.py -> fft.py and the notes), so I'll submit a PR.

@honno
Copy link
Member Author

honno commented Nov 3, 2022

I completely missed #470, which aims to do the latter point (note that these extensions must live in specified namespaces).

@rgommers
Copy link
Member

Fixed by gh-470

@rgommers rgommers added this to the v2022 milestone Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants