Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing contribution guidelines for SDK approvers #1268

Closed
artur-ciocanu opened this issue Mar 18, 2025 · 1 comment
Closed

Missing contribution guidelines for SDK approvers #1268

artur-ciocanu opened this issue Mar 18, 2025 · 1 comment
Labels
kind/bug Something isn't working

Comments

@artur-ciocanu
Copy link
Contributor

Expected Behavior

Currently the CONTRIBUTING.md file doesn't have enough instructions regarding SDK approvers. It would be good to document that:

  • Approvers might see the big 🟢 button for merge 😄 but they SHOULD NOT hit it, because permissions are NOT enforced and only maintainers should merge to main branch
  • Approvers should not use the auto-merge label, only maintainers can add this label
  • Anything else that is missing

Actual Behavior

Currently none of this is document in the CONTRIBUTING.md file.

Steps to Reproduce the Problem

Please check CONTRIBUTING.md file.

Release Note

RELEASE NOTE:

@artur-ciocanu artur-ciocanu added the kind/bug Something isn't working label Mar 18, 2025
@cicoyle
Copy link
Contributor

cicoyle commented Mar 19, 2025

I don't think this is something that should be documented in an SDK because that would bloat every SDK with the same content. This is already documented in the dapr/community repo here.

I will close this issue. Feel free to reopen it if you would like to discuss this further.

@cicoyle cicoyle closed this as completed Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants