Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about link should not open embedded #80

Open
mgiraldo opened this issue May 15, 2015 · 5 comments
Open

about link should not open embedded #80

mgiraldo opened this issue May 15, 2015 · 5 comments
Labels

Comments

@mgiraldo
Copy link
Collaborator

the behavior of the about link should be like that of a normal link

@danvk
Copy link
Owner

danvk commented May 15, 2015

This was specifically requested at our last meeting—did something change?

@mgiraldo
Copy link
Collaborator Author

what was requested? that it be shown embedded in the map?

i created a pull request with a bunch of changes including this (although doesnt have the JS.... for some reason my JS changes do not work)

@danvk
Copy link
Owner

danvk commented May 15, 2015

maybe you need to comment the bundled.js <script> and uncomment the individual ones in viewer.html?

@mgiraldo
Copy link
Collaborator Author

maybe... i don't know... i am not familiar with the way the site is built... i try to change things so that you dont have to do that but i reach some wall and cant look too much into the cabling

@danvk
Copy link
Owner

danvk commented May 15, 2015

You can also run ./update-js-bundle.sh if you prefer.

On Fri, May 15, 2015 at 4:56 PM Mauricio Giraldo [email protected]
wrote:

maybe... i don't know... i am not familiar with the way the site is
built... i try to change things so that you dont have to do that but i
reach some wall and cant look too much into the cabling


Reply to this email directly or view it on GitHub
#80 (comment).

@danvk danvk added this to the Public Release milestone May 19, 2015
@danvk danvk added the UI label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants