Skip to content

Commit b8aa604

Browse files
committed
Fix respecting serverapp.terminals_enabled
Fixes jupyter-server#85
1 parent 1f31c94 commit b8aa604

File tree

1 file changed

+5
-0
lines changed
  • jupyter_server_terminals

1 file changed

+5
-0
lines changed

jupyter_server_terminals/app.py

+5
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ class TerminalsExtensionApp(ExtensionApp):
3636

3737
def initialize_settings(self) -> None:
3838
"""Initialize settings."""
39+
if not self.serverapp.terminals_enabled:
40+
return
3941
self.initialize_configurables()
4042
self.settings.update(
4143
{"terminals_available": True, "terminal_manager": self.terminal_manager}
@@ -70,6 +72,9 @@ def initialize_configurables(self) -> None:
7072

7173
def initialize_handlers(self) -> None:
7274
"""Initialize handlers."""
75+
if not self.serverapp.terminals_enabled:
76+
# Checking self.terminals_available instead breaks enabling terminals
77+
return
7378
self.handlers.append(
7479
(
7580
r"/terminals/websocket/(\w+)",

0 commit comments

Comments
 (0)