Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference: config pyproject.toml/dagster_cloud.yaml #25

Open
dbrtly opened this issue Oct 20, 2024 · 2 comments
Open

Difference: config pyproject.toml/dagster_cloud.yaml #25

dbrtly opened this issue Oct 20, 2024 · 2 comments

Comments

@dbrtly
Copy link

dbrtly commented Oct 20, 2024

Under what circumstances are these two config intended to be different for a dagster project deployed to dagster cloud? I don't understand why
dagster_cloud.yaml is necessary.

I'm willing to contribute here.

pyproject.toml

[tool.dagster]
module_name = "quickstart_etl.definitions"
code_location_name = "quickstart_etl"

dagster_cloud.yaml

locations:
  - location_name: my_location_name # the name of the code location
    code_source:
      package_name: hackernews # the name of the python package associated with the code location

Motivation: simplify tasks required to deploy to dagster+.

@zyd14
Copy link

zyd14 commented Oct 22, 2024

How do you specify multiple code locations with pyproject.toml? Mostly just curious

@dbrtly
Copy link
Author

dbrtly commented Oct 23, 2024

How do you specify multiple code locations with pyproject.toml? Mostly just curious

I poked around in the oldest dagster docs for explanation of workspace.yaml and module_name/modules. Originally there was an idea to have something like multiple packages in your dagster workspace that had a degree of isolation for testing and execution. Seems to have been deprioritised though. Footprints of the approach still exist in the codebase.

https://github.com/dagster-io/dagster/blob/master/python_modules/dagster/dagster/_core/workspace/load_target.py#L44-L80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants