Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofix produces erroneous shorthands (second issue) #32

Open
kaevupoiss opened this issue Nov 4, 2024 · 1 comment
Open

Autofix produces erroneous shorthands (second issue) #32

kaevupoiss opened this issue Nov 4, 2024 · 1 comment

Comments

@kaevupoiss
Copy link

index.js lines 70-73

firstInlineDecl.cloneBefore({
    prop,
    value: values.length <= 2 ? values.join(' ') : `logical ${values.join(' ')}`
});

This code takes in declarations like this:

top: 0;
left: 0;
right: auto;
bottom: auto;

and results in a declaration like this:

inset: logical 0 0 auto auto;

Such logical modifier does not exist.

@kaevupoiss kaevupoiss changed the title Autofix produces erronous shorthands (second issue) Autofix produces erroneous shorthands (second issue) Nov 4, 2024
@zfeher
Copy link

zfeher commented Feb 28, 2025

We also run into this today. The invalid logical value and a wrong order of values caused visible issues for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants