Volume support #58
Merged
Volume support #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apis/civo/volume/v1alpha1/types.go
Outdated
| // +required | ||
| // +immutable | ||
| // +kubebuilder:validation:Required | ||
| Size string `json:"Size"` |
There was a problem hiding this comment.
size should be lowercase
apis/civo/volume/v1alpha1/types.go
Outdated
| type CivoVolumeObservation struct { | ||
| ID string `json:"id"` | ||
| Name string `json:"name"` | ||
| ClusterID string `json:"cluster_id"` |
There was a problem hiding this comment.
remove duplicated fields from spec
apis/civo/volume/v1alpha1/types.go
Outdated
| Size string `json:"size"` | ||
| Status string `json:"status"` | ||
| // Details regarding current state of the bucket. | ||
| Conditions []metav1.Condition `json:"conditions"` |
There was a problem hiding this comment.
we can re-use crospslane conditions
| // +kubebuilder:validation:Required | ||
| NetworkID string `json:"network_id"` | ||
|
|
||
| // ProviderReference holds configs (region, API key etc.) for the crossplane provider that is being used. |
There was a problem hiding this comment.
Missing instance id in spec
Signed-off-by: uzair <[email protected]>
| ) | ||
|
|
||
| const ( | ||
| errManagedUpdateFailed = "cannot update volume custom resource" |
There was a problem hiding this comment.
error assertion should be done with civogo
Signed-off-by: Uzair Ali <[email protected]>
|
/lgtm |
|
/approve |
vishalanarase
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested