Query array contains: fails with "PG::TextEncoder::Array"

[yosiat]

Hi,

In our codebase we work with string arrays and perform containment searches like this:

Post.all.where(Post.arel_table[:tags].contains(["tag1"]).cast(:varchar, :array)).to_a

This worked as expected in torque-postgresql v3.4.0. However, after upgrading to v3.4.1 it now fails.

Reproduction Steps

# frozen_string_literal: true

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"
  git_source(:github) { |repo| "https://github.com/#{repo}.git" }

  gem "activerecord", "7.2.2"
  gem "pg"
  gem "torque-postgresql", "3.4.1"
end

require "active_record"
require "logger"
require 'torque-postgresql'

ActiveRecord::Base.establish_connection(
  adapter:  "postgresql",
  database: "test",
  encoding: "unicode",
  host:     "localhost",
  port:     "5432",
  password: "12345",
  username: "test"
)

ActiveRecord::Schema.define do
  drop_table "posts", if_exists: true

  create_table :posts, force: true do |t|
    t.string "tags", default: [], array: true
  end
end

class Post < ActiveRecord::Base
end

Post.create!(tags: ["tag1", "tag2"])
Post.create!(tags: ["tag1", "tag3"])

pp Post.all.where(Post.arel_table[:tags].contains(["tag1"]).cast(:varchar, :array)).to_a

Failure Output

/Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/active_record/connection_adapters/abstract/quoting.rb:87:in 'ActiveRecord::ConnectionAdapters::Quoting#quote': can't quote PG::TextEncoder::Array (TypeError)

        else raise TypeError, "can't quote #{value.class.name}"
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/active_record/connection_adapters/postgresql/quoting.rb:122:in 'ActiveRecord::ConnectionAdapters::PostgreSQL::Quoting#quote'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/to_sql.rb:869:in 'Arel::Visitors::ToSql#quote'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/to_sql.rb:88:in 'Arel::Visitors::ToSql#visit_Arel_Nodes_Casted'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/torque-postgresql-3.4.1/lib/torque/postgresql/arel/visitors.rb:22:in 'Torque::PostgreSQL::Arel::Visitors#visit_Arel_Nodes_Quoted'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/visitor.rb:30:in 'Arel::Visitors::Visitor#visit'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/to_sql.rb:900:in 'block in Arel::Visitors::ToSql#inject_join'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/to_sql.rb:898:in 'Array#each'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/to_sql.rb:898:in 'Enumerable#each_with_index'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/to_sql.rb:898:in 'Arel::Visitors::ToSql#inject_join'
        from /Users/yosi/.rvm/gems/ruby-3.4.1/gems/activerecord-7.2.2/lib/arel/visitors/to_sql.rb:859:in 'Arel::Visitors::ToSql#visit_Array'

I'm not sure if this is a bug in torque-postgresql v3.4.1 or if I'm using it incorrectly. Any guidance would be appreciated!

Thanks!

[yosiat]

Hey @crashtech , I accidentally closed this issue — could you please reopen it? Thanks!