Skip to content

Commit 91b6ef2

Browse files
committed
Merge branch 'v4' into develop
# Conflicts: # src/web/assets/feedme/dist/FeedMe.js # src/web/assets/feedme/dist/FeedMe.js.map
2 parents 1d774e0 + 32cb646 commit 91b6ef2

File tree

5 files changed

+18
-5
lines changed

5 files changed

+18
-5
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Release Notes for Feed Me
22

3+
## Unreleased
4+
5+
- Fixed a bug where the Entry Type wouldn’t be remembered for related Entry fields in a feed’s mappings. ([#1387](https://github.com/craftcms/feed-me/issues/1387), [#1390](https://github.com/craftcms/feed-me/pull/1390))
6+
37
## 5.3.0 - 2023-11-27
48

59
- Added the ability to provide a filename for importing assets via the assets field if you choose to “Create asset from URL”. ([#749](https://github.com/craftcms/feed-me/issues/749))

src/templates/_includes/fields/entries.html

+3-2
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,14 @@
100100
{% endfor %}
101101

102102
{% if sources and sources[0] %}
103-
<div class="element-group element-group-entrytype" data-items="{{ entryTypes|json_encode }}">
103+
{% set selectedTypeId = hash_get(feed.fieldMapping, optionsPath ~ '.group.typeId') ?: '' %}
104+
<div class="element-group element-group-entrytype" data-items="{{ entryTypes|json_encode }}" data-selectedTypeId="{{ selectedTypeId }}">
104105
<span>{{ 'Type:'|t('feed-me') }}</span>
105106

106107
{{ forms.selectField({
107108
name: 'options[group][typeId]',
108109
class: '',
109-
value: hash_get(feed.fieldMapping, optionsPath ~ '.group.typeId') ?: '',
110+
value: selectedTypeId,
110111
options: entryTypes['item_' ~ sources[0].id] ?? [],
111112
}) }}
112113
</div>

src/web/assets/feedme/dist/FeedMe.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/web/assets/feedme/dist/FeedMe.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/web/assets/feedme/src/js/feed-me.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ $(function () {
191191
.parents('.field-extra-settings')
192192
.find('.element-group-entrytype');
193193
var sections = $container.data('items');
194+
var selectedTypeId = $container.data('selectedtypeid');
194195

195196
// var sections = $(this).parents('.element-sub-group').data('items');
196197
var entryType = 'item_' + $(this).val();
@@ -202,7 +203,14 @@ $(function () {
202203
var newOptions = '';
203204
$.each(entryTypes, function (index, value) {
204205
if (index) {
205-
newOptions += '<option value="' + index + '">' + value + '</option>';
206+
newOptions +=
207+
'<option value="' +
208+
index +
209+
'"' +
210+
(index == selectedTypeId ? ' selected="selected"' : '') +
211+
'>' +
212+
value +
213+
'</option>';
206214
}
207215
});
208216

0 commit comments

Comments
 (0)