[High Roller] Get Contract Address from apps and calculate rolls accurately #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 6, 2019 03:32
Was causing ESLint errors
Use it in High Roller cFProvider and highRoller
Falls back to Kovan if not found
|
Closing because... reasons :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
High Roller had the contract address hardcoded.
This gets the contract address from
@counterfactual/appsand uses it.This also fixes an issue with network discovery in TicTacToe
Side note:
I don't really have a way of testing these changes :)
Should this PR live in limbo until MM integration is working, so we can test this?
Related issues
Fixes: #23
Fixes: #22
Relies on: counterfactual/monorepo#2341