Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of setup order in msg server testing #7839

Closed
NisTun opened this issue Jan 12, 2025 · 1 comment · Fixed by #7840
Closed

Lack of setup order in msg server testing #7839

NisTun opened this issue Jan 12, 2025 · 1 comment · Fixed by #7840
Assignees
@NisTun

Comments

@NisTun
Copy link
Contributor

NisTun commented Jan 12, 2025

Currently, in func (suite *KeeperTestSuite) TestHandleAcknowledgePacket() at case "successful no-op: ORDERED - packet already acknowledged (replay) we missed setting up ORDERED for it here. We should add path.SetChannelOrdered() before path.Setup() to make it clear
@NisTun NisTun mentioned this issue Jan 12, 2025
Merged
10 tasks
@gjermundgaraba
Copy link
Contributor

@AdityaSripal I am not very familiar with these tests, can you verify that this is the case and if so review the linked PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NisTun NisTun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chores] add setup order for msg server test NisTun/ibc-go
2 participants
@gjermundgaraba @NisTun