Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor setup: prompts, es6, escaping, helper #661

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

m10
Copy link
Contributor

@m10 m10 commented Oct 24, 2020

  • use prompts instad of prompt package
  • rewrite with es6
  • refactor setup into helper
  • escape pagacke.json values from user input

fixes #606

related #577 (untested as of now)

Pull Request Template

The code review checklist below is used for all pull requests.

  1. Review the list before submitting your pull request.
  2. Leave the list intact for the code reviewer's use.

Checklist

  • Latest code from master has been merged into the pull request branch
  • Code is camelCased
  • No commented out code (if required, place // TODO above with explanation)
  • No linting issues
  • Automated tests exist and pass
  • Build is successful (npm run build)
  • Works in IE 11, Chrome, Firefox, and Edge

Thanks!

❤️

* use prompts instad of prompt package
* rewrite with es6
* refactor setup into helper
* escape pagacke.json values from user input
@coveralls
Copy link

coveralls commented Oct 24, 2020

Coverage Status

Coverage remained the same at 91.525% when pulling 55410b9 on m10:prompts into a7b0c61 on coryhouse:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Improve run of setup script with normalized string output for package.json
2 participants