Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xgrammar #28866

Closed
wants to merge 4 commits into from
Closed

Add xgrammar #28866

wants to merge 4 commits into from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 18, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xgrammar/recipe.yaml) and found it was in an excellent condition.

@maresb maresb closed this Jan 18, 2025
@maresb maresb reopened this Jan 18, 2025
@maresb
Copy link
Contributor Author

maresb commented Jan 18, 2025

The build is complicated by these submodules: https://github.com/mlc-ai/xgrammar/tree/main/3rdparty

Also, I'm not sure why the CI started skipping the builds.

This is likely to go stale, so others are encouraged to continue the effort.

@maresb maresb mentioned this pull request Jan 25, 2025
19 tasks
@zbowling
Copy link
Member

zbowling commented Feb 8, 2025

@maresb oh hello again. #29064

@maresb
Copy link
Contributor Author

maresb commented Feb 12, 2025

Superseded by #29064

@maresb maresb closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants