Update well-known-symbols

[novemberborn]

https://github.com/novemberborn/well-known-symbols/releases/tag/v3.0.0 adds Symbol.matchAll. I need to assess what that means for existing AVA snapshots that already include that symbol.

[ninevra]

@novemberborn sorry to nag, but might it make sense to resolve this before [email protected]?

It looks to me like declaring a symbol well-known might be a breaking change for AVA. It would cause existing snapshot assertions containing the symbol to start failing.

Have you considered dynamically determining whether a symbol is well-known, with something like:

const wellKnownSymbols = new Set(
  Reflect.ownKeys(Symbol)
    .filter(key => typeof Symbol[key] === 'symbol')
    .map(key => Symbol[key])
);

function isWellKnown(symbol) {
  return wellKnownSymbols.has(symbol);
}

[novemberborn]

@novemberborn sorry to nag, but might it make sense to resolve this before [email protected]?

No worries, it's a good point!

Have you considered dynamically determining whether a symbol is well-known

That could be interesting. I need to see how these symbols are serialized and how compatibility across JS versions is dealt with. Perhaps the logic can be adjusted so we can add well-known symbols without causing compatibility issues.

[novemberborn]

@ninevra I've decided not to tackle this for AVA 4. I'm hoping I can do some work on this package to modernize it and if need be that'll be AVA 5.