Fix grpc static in Windows with shared protobuf dependency #26556
+32
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcar87
reviewed
Feb 7, 2025
Co-authored-by: Luis Caro Campos <[email protected]>
AbrilRBS
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: grpc
Motivation
Close conan-io/conan#17703
When grpc has shared dependencies in Windows, the grpc_cpp_plugin execution can fail. The recipe already had provisioned for Linux scenario and LD_LIBRARY_PATH, but not for Windows PATH
Details
It is necessary to add
cmake/3.25to be able to correctly inject PATHs incmake -E env --modifysyntaxAlso, small removals of Conan 1 legacy dead code, and minor refactors to reduce the recipe.
I have tested manually in Windows and Linux the static-shared scenario