-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page preview #69
Comments
I've looked for a service which could put our PR page in preview mode, so I found this one: https://htmlpreview.github.io/ But we need to generate all HTML stuff and store in some place, since Travis doesn't offer artifacts download. Some thoughts about:
|
I think we are not generating the HTML files ourselves but relying on the gh-pages deployment of Github I don't see an easy way of automating the checks. The only thing would be having a script for spell checks running on travis and reporting back as a check in the PR. Something like this https://blog.eleven-labs.com/en/how-to-check-the-spelling-of-your-docs-from-travis-ci/ For the HTML preview I think it is too much to do the Bintray repo and so on... But maybe we can make travis build the HTML and post it in the PR attached in a comment? You know, I like the idea of automating but in the end it is just a blog... 📃 |
Hi!
As a Gitlab fan I need to expose a feature from there. Gitlab offers a page preview when a PR is open, the Review Apps.
Since we have typo errors, broken links and all prone errors, even when creating docs, we could adopt some service/feature to preview our PR. I think it will help us to find any kind of bad resources, before to download the fork and try on our machine.
/cc @danimtb @jgsogo
The text was updated successfully, but these errors were encountered: