-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run nbval on documentation notebooks to check documentation is up to date #132
Comments
I turned this on, but because the notebooks take a lot of time to run, Travis times out. Do you know how to stop this? |
Thanks! You can run the nbval tests on your own machine and get py.test to display the n longest running jobs (in reverse execution time order). Typically there are only a few notebooks or even cells that take a long time. We can exclude cells from execution using the nbvalskip tag. That may be a simple solution - not perfect but might be easy to achieve and keep most of the benefit. |
Working through these now:
|
This is now running all of the notebooks using a shell script workaround that prints an output every 9 minutes to keep happy. There are various issues with the notebooks themselves. I've fixed a couple but not everywhere, because some notebooks take a long time to run so I've been doing this in the background while working on other things. It seems that the Matplotlib checking in Nbval must have changed form, because all of the |
Thanks, Ryan. With Matplotlib many such tests haven broken with the change from version 2 to 3. If that is the reason, we should rund and save the reference notebook with version 3, and that should fix it. |
#153 should make unnecessary |
Might be as simple as making sure the target
test-ipynb
https://github.com/computationalmodelling/fidimag/blob/master/Makefile#L91 is run as part of the continuous integration on travis.[This should always have happened.]
A bug was reported that could have been avoided given the feedback from nbval (#131)
The text was updated successfully, but these errors were encountered: