Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] - Setup husky to run eslint and fix linter errors on pre-commit #30

Open
comoser opened this issue Oct 14, 2022 · 5 comments
Open
Labels

Comments

@comoser
Copy link
Owner

comoser commented Oct 14, 2022

Start Date

No response

Implementation PR

No response

Reference Issues

No response

Summary

We have a linter setup that should be run on the pre-commit hooks to automatically fix the issues or fail, if it can't.

Let's use husky for this.

Basic Example

N/A

Drawbacks

N/A

Unresolved questions

No response

@yhoungdev
Copy link

can you assign this to me ?

@comoser
Copy link
Owner Author

comoser commented Oct 14, 2022

go ahead @yhoungdev :)

@yhoungdev
Copy link

ok thanks

@comoser
Copy link
Owner Author

comoser commented Oct 18, 2022

ok thanks

@yhoungdev any news on the issue? I'm trying to solve quick things, so I just wanted to know how this is going 🙏

PS: did a PR that introduces husky already: #35

@comoser
Copy link
Owner Author

comoser commented Oct 19, 2022

@yhoungdev will mark this as unassigned if I don't get an answer until end of day, today GMT. I appreciate the effort, but there are more people interested in performing this task, and the more actual contributions, the better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants