Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swagger docs for API #1

Open
comoser opened this issue Oct 8, 2022 · 11 comments
Open

Add swagger docs for API #1

comoser opened this issue Oct 8, 2022 · 11 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest

Comments

@comoser
Copy link
Owner

comoser commented Oct 8, 2022

We have a postman collection in the repository, and that's great for developers. But, there may be people that want to only build the UI and don't want to rely on the postman collection to get the endpoint information.

We need to add swagger annotations appropriately to every endpoint in order to publish an open API doc for whoever wants to consume it.

@comoser comoser added documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest labels Oct 8, 2022
@jeffugo
Copy link

jeffugo commented Oct 10, 2022

Hi @comoser I'd like to work on this.

@comoser
Copy link
Owner Author

comoser commented Oct 10, 2022

Hi @comoser I'd like to work on this.

Hey @jeffugo! Feel free to pick it up, the main thing here is that it's important to expose the request and response DTOs in the controller docs for swagger.

Also, it would be good to have the authentication with the bearer token working to test the endpoints swagger provides.

@jeffugo
Copy link

jeffugo commented Oct 10, 2022

Alright, @comoser. If I may, I'll ask for clarity where I need it.

@comoser
Copy link
Owner Author

comoser commented Oct 11, 2022

Alright, @comoser. If I may, I'll ask for clarity where I need it.

Anytime you have any kind of doubt, reach out to me of course, we can clarify those here @jeffugo

@jeffugo
Copy link

jeffugo commented Oct 11, 2022

Alright @comoser. Thank you.

@jeffugo
Copy link

jeffugo commented Oct 13, 2022

Hi @comoser. I'm sorry you haven't heard from me. Been trying to figure this out in the past few days. Couldn't find any resources online to help. It appears this is a tad too technical for my skill set.

@comoser
Copy link
Owner Author

comoser commented Oct 13, 2022

Hi @comoser. I'm sorry you haven't heard from me. Been trying to figure this out in the past few days. Couldn't find any resources online to help. It appears this is a tad too technical for my skill set.

@jeffugo The solution is technical, although the result is documentation. The solutions is mostly given by the documentation of the framework used to build the API: https://docs.nestjs.com/openapi/introduction

Following that gives the first steps to solve this issue, but indeed it requires a bit of technical knowledge.

@jeffugo
Copy link

jeffugo commented Oct 13, 2022

Thanks @comoser for the link. I'll go through the resource and see if I understand it enough to go ahead. I'll let you know.

@comoser
Copy link
Owner Author

comoser commented Oct 18, 2022

@jeffugo how do you fare on this issue? :)

@jeffugo
Copy link

jeffugo commented Oct 18, 2022

Hi @comoser. I'm just getting around to studying the resource you sent. It's too technical for my current skill set. I'm so sorry for the delay and the inconvenience this may have caused.

@comoser
Copy link
Owner Author

comoser commented Oct 18, 2022

Hi @comoser. I'm just getting around to studying the resource you sent. It's too technical for my current skill set. I'm so sorry for the delay and the inconvenience this may have caused.

There's no inconvenience at all! Feel free to take your time and understand the issue. I just wanted to know if you were still invested in it, given that it's more technical than you thought :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants