Skip to content

Search [Media, Category] doesn't work #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parneet-guraya opened this issue Dec 17, 2024 · 5 comments
Closed

Search [Media, Category] doesn't work #6043

parneet-guraya opened this issue Dec 17, 2024 · 5 comments
Assignees

Comments

@parneet-guraya
Copy link
Contributor

When searching in explore page. Neither Media nor Category tab show anything. Is this isn't complete yet?

Record_2024-12-17-17-24-34.mp4

However Category search does work when uploading.


From this file, it seems like it's never implemented

https://github.com/commons-app/apps-android-commons/blob/0153cbe0ed92f2ca1a6685798e5f49bd04fe967c/app/src/main/java/fr/free/nrw/commons/explore/categories/search/SearchCategoryFragment.kt

@nicolas-raoul
Copy link
Member

I sometimes see this too.
Do you want to work on it?

Somehow sometimes it works, I got this right now, current main:
Screenshot_20241217-222343.png

@parneet-guraya
Copy link
Contributor Author

Do you want to work on it?

Yes

Somehow sometimes it works, I got this right now, current main:

Hmm.. on prodDebug only media tab works for me. Although it still throws an error (see snackbar at the bottom).

Screenshot_2024-12-17-19-09-24-58_d5db3f3edc380047609fe9c266f7c566.jpg

@nicolas-raoul
Copy link
Member

Yes I agree with you: I get that snackbar too, and the categories tab seems to never work.

@prototyperspective
Copy link

Hasn't this been fixed at #5844 ?

@parneet-guraya
Copy link
Contributor Author

Yes closing now. Also @nicolas-raoul this #5910 can also be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants