Fix one of the Android Studio warnings #5996
Comments
|
Hey, I worked on this. Here's my PR Would appreciate some feedback. Thank you! |
|
I worked on LocationPickerActivity.kt #6026 Would like clarification on whether renaming a package (to fix the weak warning "Package name part should not start with an uppercase") falls under the scope of this issue or not. |
|
@savsch Yes fixing package case-related warnings is in scope, thanks! 🙂 |
#6026) * Replace deprecated zoomLevel with zoomLevelDouble * Replace deprecated Html.fromHtml call * LocationPickerActivity: Replace deprecated methods with androidx * LocationPickerActivity: Reformatted overlong lines * Renamed package LocationPicker to locationpicker --------- Co-authored-by: Nicolas Raoul <[email protected]>
|
Hello, i an new here, and i will like to jump on this, but for clarity, one is expected to correct the errors in only one file?, can i correct errors in more than one file? |
|
@Prinuel Maybe do it for 1 file first, and if it goes well you can do for as many as you want. 🙂 |
|
Alrighty.... thanks |
|
@nicolas-raoul this issue seems to have been closed accidentally, possibly due to being linked to #6271. |
and others
This task is designed as a small, useful task to onboard new users to the codebase who are unsure about what to work on.
Important
Unique constraint to this issue
Multiple pull requests from the same author will not be accepted, unless the refactoring is part of a larger piece of work
Tip
You do not need to be assigned this issue to work on it
Android Studio flags a number of warnings in the project.
If a file which contains these warnings is committed, then Android Studio will warn the author. If the warning was not introduced by the author's commit, then the author is unnecessarily slowed down by having to confirm that they did not introduce more warnings into the codebase (which inevitably leads them to disabling the warning, as they're low value).
The list of warnings can be obtained via:
The aim of this task is to introduce new contributors to the code with an 'easy' first issue to resolve.
Code -> Inspect Codeon the solution (it will be slow)Kotlinheader is easiest.- many of the Java warnings are not flagged by the IDE)(Note to core team: Once this issue has been all completed, we can use CI to run Android Studio in headless mode to ensure that the codebase gets to, and stays at 0 warnings.)
The text was updated successfully, but these errors were encountered: