Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zero create: defaultBranch cmd output from git includes linebreak #434

Open
davidcheung opened this issue Nov 5, 2021 · 2 comments
Open

zero create: defaultBranch cmd output from git includes linebreak #434

davidcheung opened this issue Nov 5, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good first ticket, minimal dependencies

Comments

@davidcheung
Copy link
Contributor

looks like the command comes back with a \n in the content, will have to trim this out or creation can fail

DEBUG[2021-11-05T14:43:21-04:00] Running (git) command in ./frontend0818-test, []string{"push", "-u", "origin", "master\n"}
@davidcheung davidcheung added bug Something isn't working good first issue Good first ticket, minimal dependencies labels Nov 5, 2021
@aserputov
Copy link

Hey, @davidcheung, I would like to work on this issue. Could you please assign it to me?

@davidcheung
Copy link
Contributor Author

Thanks @aserputov!! 🎉

aserputov pushed a commit to aserputov/Zero that referenced this issue Nov 19, 2021
Update issue commitdev#434: trim \n out
4937a10
@aserputov aserputov mentioned this issue Nov 19, 2021
Closed
@aserputov aserputov removed their assignment Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good first ticket, minimal dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update issue #434: trim \n out aserputov/Zero
2 participants
@davidcheung @aserputov