Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra logging around the curl calls in each module's check functions #432

Open
bmonkman opened this issue Nov 4, 2021 · 0 comments
Open
Labels
enhancement good first issue Good first ticket, minimal dependencies module

Comments

@bmonkman
Copy link
Contributor

bmonkman commented Nov 4, 2021

The check function in gha-setup.sh in the application modules (backend-go, backend-node, frontend-react, static-gatsby) run a script to check for binaries and then do a curl call to github to verify that the user has a token that can be used with each repository.
If this fails it just outputs false.
https://github.com/commitdev/zero-backend-node/blob/1376ac0e7ff4448d641633c0ff69f602acbeebf4/scripts/gha-setup.sh#L66-L67

If this call fails we should have a more descriptive error message like "The GitHub token entered is unable to make requests to the GitHub API for this repository. This is required for setting up GitHub Actions pipelines.\nPlease verify your token, its access, and make sure this repository has been created in your organization."

@bmonkman bmonkman added enhancement good first issue Good first ticket, minimal dependencies module labels Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good first ticket, minimal dependencies module
Projects
None yet
Development

No branches or pull requests

1 participant