fix(gitlab): ignore updated event (#279)

Author: colinlienard

.stylelintrc

@@ -12,11 +12,7 @@
 		"custom-property-empty-line-before": "never",
 		"no-descending-specificity": null,
 		"property-no-vendor-prefix": null,
-		"selector-pseudo-class-no-unknown": [
-			true,
-			{
-				"ignorePseudoClasses": ["global"]
-			}
-		]
+		"selector-pseudo-class-no-unknown": [true, { "ignorePseudoClasses": ["global"] }],
+		"scss/no-global-function-names": null
 	}
 }

src/lib/features/createGitlabNotificationData.ts

@@ -68,17 +68,21 @@ export async function prepareGitlabNotificationData(events: GitlabEventWithRepoD
 				) {
 					type = 'Issue';
 				}
-				const data = await fetchGitlab<GitlabMergeRequest | GitlabIssue>(
-					`projects/${firstEvent.repository.encoded}/${
-						type === 'Issue' ? 'issues' : 'merge_requests'
-					}/${isNote ? firstEvent.note.noteable_iid : firstEvent.target_iid}`
-				);
-				return {
-					target_id: item.target_id,
-					ref: item.ref,
-					events: item.events,
-					data
-				};
+				try {
+					const data = await fetchGitlab<GitlabMergeRequest | GitlabIssue>(
+						`projects/${firstEvent.repository.encoded}/${
+							type === 'Issue' ? 'issues' : 'merge_requests'
+						}/${isNote ? firstEvent.note.noteable_iid : firstEvent.target_iid}`
+					);
+					return {
+						target_id: item.target_id,
+						ref: item.ref,
+						events: item.events,
+						data
+					};
+				} catch {
+					return item;
+				}
 			} else {
 				return item;
 			}
@@ -262,6 +266,7 @@ export async function createGitlabNotificationData(
 		case 'created':
 		case 'deleted':
 		case 'joined':
+		case 'updated':
 			return null;
 
 		default:

src/lib/types/gitlab-types.ts

@@ -93,6 +93,12 @@ export type GitlabEvent = {
 			target_iid: number;
 			target_type: null;
 	  }
+	| {
+			action_name: 'updated';
+			target_id: number;
+			target_iid: number;
+			target_type: null;
+	  }
 	| {
 			action_name: 'approved';
 			target_id: number;

src/routes/(app)/dashboard/+page.svelte

@@ -213,7 +213,12 @@
 
 		let newNotifications: NotificationData[] = [];
 		const savedNotifications = storage.get('gitlab-notifications') || [];
-		const ignoredNotificationTypes: GitlabEvent['action_name'][] = ['created', 'deleted', 'joined'];
+		const ignoredNotificationTypes: GitlabEvent['action_name'][] = [
+			'created',
+			'deleted',
+			'joined',
+			'updated'
+		];
 		const persons = storage.get('watched-persons') || [];
 		const repos = storage.get('watched-repos') || [];
 		const firstFetch = !$gitlabNotifications.length;