Skip to content

Commit b898321

Browse files
authoredMay 3, 2020
Merge pull request #307 from coderoad/feature/fix-continue
Feature/fix continue
2 parents 32eb6bd + e076deb commit b898321

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed
 

Diff for: ‎src/channel/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ class Channel implements Channel {
8383

8484
// load continued tutorial position & progress
8585
const { position, progress } = await this.context.setTutorial(this.workspaceState, tutorial)
86+
logger('CONTINUE STATE', position, progress)
8687

8788
if (progress.complete) {
8889
// tutorial is already complete

Diff for: ‎src/channel/state/Progress.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class Progress {
5353
throw new Error(`setStepComplete level not found for stepId ${stepId}`)
5454
}
5555

56-
if (currentLevel.steps[currentLevel.steps.length - 1]) {
56+
if (currentLevel.steps[currentLevel.steps.length - 1].id === stepId) {
5757
// final step for level is complete
5858
next.levels[currentLevel.id] = true
5959

Diff for: ‎src/environment.ts

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,19 @@
1-
require('dotenv').config({
2-
path: './web-app/.env',
3-
})
4-
51
import { getWorkspaceRoot } from './services/workspace'
62
import * as os from 'os'
73

84
// CodeRoad version
9-
export const VERSION: string = process.env.npm_package_version || 'unknown'
5+
export const VERSION = 'unknown'
106

117
// Node env
128
export type Env = 'test' | 'local' | 'development' | 'production'
139
// @ts-ignore
1410
export const NODE_ENV: Env = process.env.NODE_ENV || 'production'
1511

1612
// toggle logging in development
17-
export const LOG: boolean = (process.env.REACT_APP_LOG || '').toLowerCase() === 'true'
13+
export const LOG = false
1814

1915
// error logging tool
20-
export const SENTRY_DSN: string | null = process.env.SENTRY_DSN || null
16+
export const SENTRY_DSN: string | null = null
2117

2218
// uri path to the users project workspace
2319
export const WORKSPACE_ROOT: string = getWorkspaceRoot()

Diff for: ‎src/services/logger/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { LOG } from '../../environment'
22

3-
export type Log = string | object | null | undefined
3+
export type Log = string | number | object | null | undefined
44

55
const logger = (...messages: Log[]): void => {
66
if (!LOG) {

0 commit comments

Comments
 (0)
Please sign in to comment.