Show backtrace in table and show severity in email subject

Author: codergeek121

app/views/email_error_reporter/error_mailer/_frame.html.erb

@@ -1 +1,3 @@
-<li><%= frame %></li>
+<tr>
+  <td><%= frame %></td>
+</tr>

app/views/email_error_reporter/error_mailer/_no_backtrace.html.erb

@@ -1 +1 @@
-<p>No backtrace available</p>
+<tr><td>No backtrace available</td></tr>

app/views/email_error_reporter/error_mailer/error.html.erb

@@ -2,5 +2,7 @@
 <p><%= @error.message %></p>
 
 <div>
-<%= render(partial: "frame", collection: @backtrace) || render("no_backtrace") -%>
+  <table border="1">
+    <%= render(partial: "frame", collection: @backtrace) || render("no_backtrace") -%>
+  </table>
 </div>

lib/email_error_reporter/error_mailer.rb

@@ -9,8 +9,14 @@ def error(error, handled:, severity:, context:, source: nil)
 
       @backtrace = Array.wrap(error.backtrace)
 
+      severity_to_emoji = {
+        error: "🔥",
+        warning: "⚠️",
+        info: "ℹ️"
+      }
+
       mail(
-        subject: "#{error.class}",
+        subject: "#{severity_to_emoji.fetch(@severity)}  #{error.class}",
         to: Rails.application.config.email_error_reporter.to
       )
     end

test/dummy/test/fixtures/email_error_reporter/error_mailer/error

@@ -2,5 +2,7 @@
 <p>some message</p>
 
 <div>
-<p>No backtrace available</p>
+  <table border="1">
+    <tr><td>No backtrace available</td></tr>
+  </table>
 </div>

test/dummy/test/fixtures/email_error_reporter/error_mailer/error_with_backtrace

@@ -2,6 +2,12 @@
 <p>some message</p>
 
 <div>
-<li>foo</li>
-<li>bar</li>
+  <table border="1">
+    <tr>
+  <td>foo</td>
+</tr>
+<tr>
+  <td>bar</td>
+</tr>
+  </table>
 </div>

test/error_mailer_test.rb

@@ -1,30 +1,46 @@
 require "test_helper"
 
 class EmailErrorReporter::ErrorMailerTest < ActionMailer::TestCase
+  setup do
+    @exception = Exception.new("some message")
+  end
+
   test "renders the template correctly" do
-    exception = Exception.new("some message")
-    email = EmailErrorReporter::ErrorMailer.error(
-      exception,
-      handled: true,
-      severity: :info,
-      context: {}
-    )
-    assert_equal [], email.to
-    assert_equal "Exception", email.subject
-    assert_equal read_fixture("error").join, email.body.to_s
+    assert_equal [], error_mail.to
+    assert_equal read_fixture("error").join, error_mail.body.to_s
   end
 
   test "renders a backtrace" do
-    exception = Exception.new("some message")
-    exception.set_backtrace(["foo", "bar"])
+    @exception.set_backtrace(["foo", "bar"])
+
+    assert_equal [], error_mail.to
+    assert_equal read_fixture("error_with_backtrace").join, error_mail.body.to_s
+  end
+
+  test "severity: error" do
+    email = error_mail(severity: :error)
+    assert_equal "🔥" + "  Exception", email.subject
+  end
+
+  test "severity: warning" do
+    email = error_mail(severity: :warning)
+    assert_equal "⚠️" + "  Exception", email.subject
+  end
+
+  test "severity: info" do
+    email = error_mail(severity: :info)
+    assert_equal "ℹ️" + "  Exception", email.subject
+  end
+
+  private
+
+  def error_mail(**kwargs)
     email = EmailErrorReporter::ErrorMailer.error(
-      exception,
+      @exception,
       handled: true,
       severity: :info,
-      context: {}
+      context: {},
+      **kwargs
     )
-    assert_equal [], email.to
-    assert_equal "Exception", email.subject
-    assert_equal read_fixture("error_with_backtrace").join, email.body.to_s
   end
 end