Skip to content

Workspace Query Edge Case #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Crain-32 opened this issue Nov 28, 2024 · 5 comments
Open

Workspace Query Edge Case #505

Crain-32 opened this issue Nov 28, 2024 · 5 comments

Comments

@Crain-32
Copy link

Currently given a gateway URL like the following,
jetbrains-gateway://connect#type=coder&workspace=other-workspace&owner=user-a&etc=...
the LinkHandler which gets executed has a missing edge case.

Mainly that you'll always fail to find the Workspaces unless you are the owner of the Workspace. This is due to not setting the CoderSettings.workspaceFilter before doing the client.workspaces() call. Which is problematic in a large scale organization where custom roles might be at play, and non-owners have access to a workspace.

@coder-labeler coder-labeler bot added the help wanted Extra attention is needed label Nov 28, 2024
@matifali
Copy link
Member

Thank you for the report. @code-asher can you take a look on how best we can handle this and if there are existing workarounds for this.

@code-asher
Copy link
Member

At the moment, if you want to access someone else's workspaces, you have to put their name in the workspace filter setting. Or you have to remove the filter, but this can be very, very slow.

I would like to remove this restriction/requirement altogether, but to do that we need wildcard host names first: coder/coder#14986

@matifali matifali removed the help wanted Extra attention is needed label Dec 3, 2024
@matifali
Copy link
Member

@code-asher, as we now have a wildcard host in coder config-ssh. Do you think the OP's issue is solved or solveable? @bcpeinhardt can you help here too? Thanks.

@code-asher
Copy link
Member

code-asher commented Mar 26, 2025

I think this might be solved, although I am not sure anyone has specifically tested the case of connecting to someone else's workspace from the dashboard yet, so we may want to verify that. Although the SSH config uses wildcards, I am not completely sure if the link handler makes other queries that need to be fixed.

@Crain-32
Copy link
Author

I'm currently OOO (Or I'd verify the connection question)
I'll be back in Office the third week of April, at which point I could test it.

Once the Dashboard question is answered (either by my verification or someone else's), I'll consider this closed. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants