-
Notifications
You must be signed in to change notification settings - Fork 15
Workspace Query Edge Case #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for the report. @code-asher can you take a look on how best we can handle this and if there are existing workarounds for this. |
At the moment, if you want to access someone else's workspaces, you have to put their name in the workspace filter setting. Or you have to remove the filter, but this can be very, very slow. I would like to remove this restriction/requirement altogether, but to do that we need wildcard host names first: coder/coder#14986 |
@code-asher, as we now have a wildcard host in |
I think this might be solved, although I am not sure anyone has specifically tested the case of connecting to someone else's workspace from the dashboard yet, so we may want to verify that. Although the SSH config uses wildcards, I am not completely sure if the link handler makes other queries that need to be fixed. |
I'm currently OOO (Or I'd verify the connection question) Once the Dashboard question is answered (either by my verification or someone else's), I'll consider this closed. Thanks everyone! |
Currently given a gateway URL like the following,
jetbrains-gateway://connect#type=coder&workspace=other-workspace&owner=user-a&etc=...
the LinkHandler which gets executed has a missing edge case.
Mainly that you'll always fail to find the Workspaces unless you are the owner of the Workspace. This is due to not setting the
CoderSettings.workspaceFilter
before doing the client.workspaces() call. Which is problematic in a large scale organization where custom roles might be at play, and non-owners have access to a workspace.The text was updated successfully, but these errors were encountered: