Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH connection to a Workspace is established only once #38

Closed
fioan89 opened this issue Mar 18, 2025 · 0 comments · Fixed by #76
Closed

SSH connection to a Workspace is established only once #38

fioan89 opened this issue Mar 18, 2025 · 0 comments · Fixed by #76
Milestone
Toolbox launch

Comments

@fioan89
Copy link
Collaborator

fioan89 commented Mar 18, 2025

SSH automatically connects when a user selects a workspace from the main env. page. However, once the user chooses to disconnect there is SSH no longer automatically connects to that workspace.

Screen.Recording.2025-03-19.at.00.01.40.mov
@matifali matifali added this to the v0.1.0 milestone Mar 26, 2025
fioan89 added a commit that referenced this issue Apr 9, 2025
@fioan89
fix: ssh connection to a workspace is established only once
Loading
Loading status checks…
4a7a287 
- right now ssh automatically connects to the workspace when a user selects it from the main env. page.
  However, if the user manually disconnects from the hamburger menu, the SSH is no longer automatically
  established afterward.
- the reason for this behavior was that the connection request flag that triggered the ssh connection behind
  the scenes was never reset. In order to reset we have to know when a user hits the disconnect button.
- fortunately Toolbox provides two callbacks, one before establishing the ssh connection and another one right
  after disconnect. Even though we don't know the reason for disconnect it's still a good opportunity to
  reset the request flag.

- resolves #38
@fioan89 fioan89 mentioned this issue Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Toolbox launch
Development

Successfully merging a pull request may close this issue.

fix: ssh connection to a workspace is established only once coder/coder-jetbrains-toolbox
2 participants
@fioan89 @matifali