Skip to content

[bug] small typo #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jetzhou opened this issue Feb 6, 2025 · 3 comments
Open

[bug] small typo #344

jetzhou opened this issue Feb 6, 2025 · 3 comments

Comments

@jetzhou
Copy link

jetzhou commented Feb 6, 2025

I noticed that the system prompts generated when using create -d <description> has a small typo in the delimiters. The prompt generated follows this template

Hey CodegenBot! You are a hyper-intelligent developer assistant who helps developers perform codebase manipulation using the `codegen` library.

Here is full documentation of the `codegen` library:
>>>>>>>>>>>>>>>>>>>> START CODEGEN DOCS <<<<<<<<<<<<<<<<<<<<

(codegen docs)

>>>>>>>>>>>>>>>>>>>> END CODEGEN DOCS <<<<<<<<<<<<<<<<<<<<

Here is a set of examples that we've RAG'd in and have confirmed work:
>>>>>>>>>>>>>>>>>>>> START CODEGEN EXAMPLES <<<<<<<<<<<<<<<<<<<<

(codegen examples)

>>>>>>>>>>>>>>>>>>>> END CODEGEN DOCS <<<<<<<<<<<<<<<<<<<<

These were generated in response to the original use request:
>>>>>>>>>>>>>>>>>>>> START CODEGEN REQUEST <<<<<<<<<<<<<<<<<<<<
(request)
>>>>>>>>>>>>>>>>>>>> END CODEGEN REQUEST <<<<<<<<<<<<<<<<<<<<

Typo is the second END CODEGEN DOCS, which should have been END CODEGEN EXAMPLES. The prompt is a response generated by CREATE_ENDPOINT i.e. f"https://{MODAL_PREFIX}--cli-create.modal.run".

@jayhack
Copy link
Contributor

jayhack commented Feb 12, 2025

Thanks for flagging @jetzhou !

@christinewangcw christinewangcw changed the title [Bug report] small typo [bug] small typo Feb 26, 2025
@jayhack
Copy link
Contributor

jayhack commented Apr 3, 2025

@codegen please fix this!

Hey! 👋 Taking a look.
💻 View my work.

Copy link
Contributor

codegen-sh bot commented Apr 3, 2025

📝 View PR #1011 📝

Hi @jet Zhou! I've created a PR that documents the typo in the system prompt template. The issue is that when using create -d <description>, the last delimiter incorrectly says END CODEGEN DOCS when it should say END CODEGEN EXAMPLES.

The fix needs to be applied in the backend implementation of the cli-create.modal.run endpoint. I've documented the issue and the correct template in the system-prompt-typo.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants