-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card items overflow out of cards #1768
Comments
Spec for solution: let's pick upto 3 languages. Prioritize based on this ordered list:
|
"Hi @rohitpaulk, is this issue still relevant to work on? If yes, could you provide more details or context to help improve it? |
@yuvrajkarna2717 yep! We should limit to 3 icons, you'll find the spec above here: #1768 (comment) |
Hey, what should I add in .env, backend url? This should match the URL defined in
|
You can use our staging server to develop against. |
ok thanks |
Added this to our default |
I am wondering, how can I check my code is working or not, as I cannot reproduce the bug. Any help please. |
@Wassaf001 you can try editing this file to mimic the scenario: https://github.com/codecrafters-io/frontend/blob/main/tests/acceptance/view-user-profile-test.js. You can add |
ok thank you. |
@Wassaf001 one thing I'm noticing is that in the first screenshot I have three completed languages - PHP, TS and Kotlin, but in the second it only shows 2 (would have expected 3). Would recommend opening a PR anyway! Easier to share feedback when we have concrete code to look at. |
ok will do that. |
I have opened a PR, what is the process further, if any change or improvement is required let me know, I will do it. |
Details
Steps
(firefox)

(chromium)

Proposed solution
Make sure the icons don't overflow
The text was updated successfully, but these errors were encountered: