Merge pull request #24 from codecrafters-io/add-monitoring

libmartinito · web-flow · commit a72a281df051 · 2024-05-31T22:42:22.000+08:00
CC-1212 Add monitoring for unexpected build status in cli
diff --git a/internal/utils/codecrafters_client.go b/internal/utils/codecrafters_client.go
@@ -8,6 +8,7 @@ import (
 	"time"
 
 	retry "github.com/avast/retry-go"
+	"github.com/getsentry/sentry-go"
 	"github.com/levigross/grequests"
 	"github.com/mitchellh/go-wordwrap"
 )
@@ -190,7 +191,10 @@ func (c CodecraftersClient) FetchBuild(buildId string) (FetchBuildStatusResponse
 			}
 
 			if fetchBuildResponse.Status != "failure" && fetchBuildResponse.Status != "success" {
-				return fmt.Errorf("unexpected build status: %s", fetchBuildResponse.Status)
+				err = fmt.Errorf("unexpected build status: %s", fetchBuildResponse.Status)
+
+				sentry.CaptureException(err)
+				return err
 			}
 
 			return nil

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ import (`
`8`	`8`	`"time"`
`9`	`9`
`10`	`10`	`retry "github.com/avast/retry-go"`
	`11`	`+ "github.com/getsentry/sentry-go"`
`11`	`12`	`"github.com/levigross/grequests"`
`12`	`13`	`"github.com/mitchellh/go-wordwrap"`
`13`	`14`	`)`
`@@ -190,7 +191,10 @@ func (c CodecraftersClient) FetchBuild(buildId string) (FetchBuildStatusResponse`
`190`	`191`	`}`
`191`	`192`
`192`	`193`	`if fetchBuildResponse.Status != "failure" && fetchBuildResponse.Status != "success" {`
`193`		`- return fmt.Errorf("unexpected build status: %s", fetchBuildResponse.Status)`
	`194`	`+ err = fmt.Errorf("unexpected build status: %s", fetchBuildResponse.Status)`
	`195`	`+`
	`196`	`+ sentry.CaptureException(err)`
	`197`	`+ return err`
`194`	`198`	`}`
`195`	`199`
`196`	`200`	`return nil`