Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov Uploads prevent common error conditions #2545

Open
trent-codecov opened this issue Sep 18, 2024 · 0 comments
Open

Codecov Uploads prevent common error conditions #2545

trent-codecov opened this issue Sep 18, 2024 · 0 comments
Labels
epic this label is used to mark issues as epics P2: stretch priority <=6
Milestone

Comments

@trent-codecov
Copy link
Contributor

trent-codecov commented Sep 18, 2024

With the multi step upload process, it is possible to upload things in the wrong order or omit a required step.

Goal:

Each step should perform the steps before it in the event that it is not completed.

  • create report should check for commit and instead of failing, it would call create commit.
  • create upload should check for report and commit and instead of failing, it would call create commit and/or report.

Considerations:

  • Create commit and create report call celery tasks. Suggestion is to use celery task chaining to prevent ordering issues.
  • Create commit and create report have different method signatures. The truly required info is present. However modifying the CLI to send the option info on create commit into the create report / create commit methods will allow this functionality to work better by default.
@codecov-hooky codecov-hooky bot added the epic this label is used to mark issues as epics label Sep 19, 2024
@trent-codecov trent-codecov added this to the Q4 '24 milestone Sep 19, 2024
@trent-codecov trent-codecov added the P2: stretch priority <=6 label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic this label is used to mark issues as epics P2: stretch priority <=6
Projects
None yet
Development

No branches or pull requests

1 participant