Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fails to upload coverage if multiple files are specified #1728

Open
hameerabbasi opened this issue Dec 19, 2024 · 3 comments
Open

Windows fails to upload coverage if multiple files are specified #1728

hameerabbasi opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@hameerabbasi
Copy link

See log lines here.

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Dec 25, 2024
@thomasrockhu-codecov thomasrockhu-codecov added Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months Area: Report Upload Issues with pre-ingest report uploading labels Dec 25, 2024
@thomasrockhu-codecov
Copy link
Contributor

@hameerabbasi I'm off until the new year, I'll look at this when I get back. I think this may be a problem with the way we do globbing

@hameerabbasi
Copy link
Author

Copying the log lines here as GH actions logs aren't permanent:

==> Running upload-coverage
      ./codecov.exe  upload-coverage -t <redacted> --git-service github --file ./**/coverage*.xml --gcov-executable gcov
info - 2024-12-19 06:59:58,262 -- ci service found: github-actions
Usage: codecov.exe upload-coverage [OPTIONS]
Try 'codecov.exe upload-coverage -h' for help.

Error: Got unexpected extra arguments (.\coverage_MLIR.xml .\coverage_Numba.xml)

@thomasrockhu-codecov
Copy link
Contributor

thomasrockhu-codecov commented Jan 30, 2025

@hameerabbasi I'm almost positive this is a glob issue right now. I have an issue slated next month to work on adding proper glob support to the underlying CLI, but I'm afraid for now, the workaround is to do something like

- name: Upload coverage to Codecov
  uses: codecov/codecov-action@v5
  with:
    token: ${{ secrets.CODECOV_TOKEN }}
    files: coverage_MLIR.xml,coverage_Numba.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

2 participants