Skip to content

Commit 3252bb7

Browse files
authored
Audit and organize dependencies (#148)
* Promote SimpleCov to a runtime depenency * Extract ruby 1.9 dependencies to separate Gemfile Inspired by: * a0e5d03#commitcomment-19735625 * #146 (comment)
1 parent 3d77234 commit 3252bb7

File tree

6 files changed

+28
-21
lines changed

6 files changed

+28
-21
lines changed

Diff for: .gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
.yardoc
66
*.DS_Store
77
Gemfile.lock
8+
Gemfile.ruby-19.lock
89
InstalledFiles
910
_yardoc
1011
coverage

Diff for: Gemfile

-9
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
11
source "https://rubygems.org"
22

3-
# Specify your gem's dependencies in codeclimate-test-reporter.gemspec
43
gemspec
5-
6-
platform :ruby_19 do
7-
gem "pry-debugger", group: :development
8-
end
9-
10-
platform :ruby_21 do
11-
gem "pry-byebug", group: :development
12-
end

Diff for: Gemfile.ruby-19

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
source "https://rubygems.org"
2+
3+
gem "addressable", "< 2.5"
4+
gem "json", "~> 1.8", "< 2"
5+
6+
gemspec

Diff for: bin/ci

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
#!/bin/bash --login
2+
3+
set -e
4+
5+
rvm use 1.9.3
6+
ruby -v
7+
bundle install --gemfile Gemfile.ruby-19
8+
bundle exec rake
9+
10+
rvm use 2.2.2
11+
ruby -v
12+
bundle install
13+
bundle exec rake
14+
15+
bundle exec codeclimate-test-reporter

Diff for: circle.yml

+2-6
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,8 @@ dependencies:
33
- git config --global user.email "[email protected]"
44
- git config --global user.name "Code Climate CI"
55
override:
6-
- rvm 1.9.3 do bundle install
7-
- rvm 2.2.2 do bundle install
8-
6+
- echo "skip"
97

108
test:
119
override:
12-
- rvm 1.9.3 do bundle exec rake
13-
- rvm 2.2.2 do bundle exec rake
14-
- rvm 2.2.2 do bundle exec bin/codeclimate-test-reporter
10+
- bin/ci

Diff for: codeclimate-test-reporter.gemspec

+4-6
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,14 @@ Gem::Specification.new do |spec|
1111
spec.license = "MIT"
1212

1313
spec.files = `git ls-files bin lib config LICENSE.txt README.md`.split($/)
14-
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
14+
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }.reject { |f| f == "ci" }
1515

1616
spec.required_ruby_version = ">= 1.9"
17+
spec.add_runtime_dependency "simplecov"
1718

18-
spec.add_development_dependency "simplecov"
19-
spec.add_development_dependency "bundler", "~> 1.3"
19+
spec.add_development_dependency "bundler"
20+
spec.add_development_dependency "pry"
2021
spec.add_development_dependency "rake"
2122
spec.add_development_dependency "rspec"
2223
spec.add_development_dependency "webmock"
23-
spec.add_development_dependency "pry"
24-
spec.add_development_dependency "addressable", "< 2.5" if RUBY_VERSION < "2"
25-
spec.add_development_dependency "json", "~> 1.8", "< 2" if RUBY_VERSION < "2"
2624
end

0 commit comments

Comments
 (0)