Updates

Author: brynary

1-value-objects/1_constant.rb

@@ -14,17 +14,11 @@ def rating_higher_than?(other_rating)
   end
 
   def rating_string
-    if remediation_cost <= 2
-      "A"
-    elsif remediation_cost <= 4
-      "B"
-    elsif remediation_cost <= 8
-      "C"
-    elsif remediation_cost <= 16
-      "D"
-    else
-      "F"
+    if    remediation_cost <= 2  then "A"
+    elsif remediation_cost <= 4  then "B"
+    elsif remediation_cost <= 8  then "C"
+    elsif remediation_cost <= 16 then "D"
+    else "F"
     end
   end
-
 end

1-value-objects/2_rating.rb

@@ -2,23 +2,26 @@ class Rating
   include Comparable
 
   def self.from_cost(cost)
-    if cost <= 2
-      new("A")
-    elsif cost <= 4
-      new("B")
-    elsif cost <= 8
-      new("C")
-    elsif cost <= 16
-      new("D")
-    else
-      new("F")
+    if    cost <= 2  then new("A")
+    elsif cost <= 4  then new("B")
+    elsif cost <= 8  then new("C")
+    elsif cost <= 16 then new("D")
+    else new("F")
     end
   end
 
   def initialize(letter)
     @letter = letter
   end
 
+  def to_s
+    @letter.to_s
+  end
+
+  def <=>(other)
+    other.to_s <=> to_s
+  end
+
   def worse
     return nil if @letter == "F"
     self.class.new(@letter.succ)
@@ -28,19 +31,11 @@ def higher_than?(other)
     self > other
   end
 
-  def <=>(other)
-    other.to_s <=> to_s
-  end
-
   def hash
     @letter.hash
   end
 
   def eql?(other)
     to_s == other.to_s
   end
-
-  def to_s
-    @letter.to_s
-  end
 end

2-service-objects/2_password_authenticator.rb

@@ -4,7 +4,12 @@ def initialize(user)
   end
 
   def authenticate(unencrypted_password)
-    return false unless @user
-    BCrypt::Password.new(@user.password_digest) == unencrypted_password
+    @user && bcrypt_password == unencrypted_password
+  end
+
+private
+
+  def bcrypt_password
+    BCrypt::Password.new(@user.password_digest)
   end
 end

2-service-objects/2_token_authenticator.rb

@@ -10,7 +10,6 @@ def authenticate(provided_token)
 
 private
 
-  # constant-time comparison algorithm to prevent timing attacks
   def secure_compare(a, b)
     return false unless a.bytesize == b.bytesize
     l = a.unpack "C#{a.bytesize}"

3-form-objects/1_user.rb

@@ -1,6 +1,3 @@
-# 1. What if the user fails to save after saving the company?
-# 2. wtf does user#company return? strings?
-# 3. how do you create _just_ a fscking user
 class User < ActiveRecord::Base
   attr_accessor :company
 

4-query-objects/1_account.rb

@@ -4,16 +4,15 @@ class Account < ActiveRecord::Base
   def self.importable_accounts
     where(enabled: true).
       where("failed_attempts_count <= 3").
-      joins("LEFT OUTER JOIN import_attempts ON account_id = accounts.id").
+      joins("LEFT JOIN import_attempts ON account_id = accounts.id").
       order('last_attempt_at ASC').
       preload(:credentials)
   end
 
   def self.import_failed_accounts
     where("failed_attempts_count >= 3")
-      joins("LEFT OUTER JOIN import_attempts ON account_id = accounts.id")
+      joins("LEFT JOIN import_attempts ON account_id = accounts.id")
       order('failed_attempts_count DESC').
       preload(:credentials)
   end
-
 end

4-query-objects/2_importable_accounts_query.rb

@@ -7,7 +7,7 @@ def find_each(&block)
     @relation.
       where(enabled: true).
       where("failed_attempts_count <= 3").
-      joins("LEFT OUTER JOIN import_attempts ON account_id = accounts.id").
+      joins("LEFT JOIN imports ON account_id = accounts.id").
       order('last_attempt_at ASC').
       preload(:credentials).
       find_each(&block)

4-query-objects/3_import_accounts_job.rb

@@ -1,6 +1,7 @@
 class ImportAccountsJob < Job
   def run
-    ImportableAccountsQuery.new.find_each do |account|
+    query = ImportableAccountsQuery.new
+    query.find_each do |account|
       AccountImporter.new(account).run
     end
   end

4-query-objects/4_relation_composition.rb

@@ -1,2 +1,2 @@
 old_accounts = Account.where("created_at < ?", 1.month.ago)
-old_importable_accounts = ImportableAccountsQuery.new(old_accounts)
+ImportableAccountsQuery.new(old_accounts)

5-view-objects/1_user.rb

@@ -15,5 +15,4 @@ def onboarding_progress_percent
     score += 1 if @user.sent_invites?
     (score / 2.0 * 100)
   end
-
 end

6-policy-objects/1_user.rb

@@ -6,5 +6,4 @@ def deliver_notification?(notification_type, project = nil)
     receive_notification_type?(notification_type) &&
     (!project || receives_notifications_for?(project))
   end
-
 end

6-policy-objects/2_email_notification_policy.rb

@@ -1,12 +1,11 @@
 class EmailNotificationPolicy
-
   def initialize(user, notification_type, project = nil)
     @user = user
     @notification_type = notification_type
     @project = project
   end
 
-  def email?
+  def deliver?
     !@user.hard_bounce? &&
     @user.receive_notification_type?(notification_type) &&
     receives_project_emails?
@@ -15,7 +14,7 @@ def email?
 private
 
   def receives_project_emails?
-    (!@project || @user.receives_notifications_for?(@project))
+    !@project ||
+    @user.receives_notifications_for?(@project)
   end
-
 end

7-decorators/1_order.rb

@@ -2,25 +2,11 @@ class Order < ActiveRecord::Base
   # ...
   attr_accessor :placed_online
 
-  after_create :notify_warehouse
   after_create :email_receipt, if: :placed_online
-  after_create :post_to_facebook, if: :send_to_facebook?
 
 private
 
-  def notify_warehouse
-    WarehouseApi.notify(sku, quanity)
-  end
-
   def email_receipt
     OrdersMailer.receipt(self).deliver
   end
-
-  def send_to_facebook?
-    placed_online && customer.facebook_enabled?
-  end
-
-  def post_to_facebook
-    FacebookApi.post_to_wall("I just bought #{product_name} from MyStoreCo!")
-  end
 end

7-decorators/2_order_email_notifier.rb

@@ -0,0 +1,10 @@
+class OrderEmailNotifier
+  def initialize(order)
+    @order = order
+  end
+
+  def save
+    @order.save &&
+    OrdersMailer.receipt(@order).deliver
+  end
+end

7-decorators/2_warehouse_notifier.rb

@@ -19,3 +19,6 @@ def build_order
   end
 
 end
+
+
+# Can you read this?